Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: select treenode on snyk showdocument [IDE-957] #260

Merged
merged 21 commits into from
Mar 3, 2025
Merged

feat: select treenode on snyk showdocument [IDE-957] #260

merged 21 commits into from
Mar 3, 2025

Conversation

acke
Copy link
Contributor

@acke acke commented Feb 24, 2025 •
edited
Loading

Description

Will select the treenode when a code lens or a code action is triggered.
Will display the issue in details view.

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

@acke acke changed the title feat: select treenode on snyk showdocument WIP feat: select treenode on snyk showdocument [WIP] Feb 24, 2025
@acke acke force-pushed the feat/IDE-957_code_action_opens_issue_panel branch from 7655879 to 269c2ae Compare February 24, 2025 21:46
@acke acke marked this pull request as ready for review February 25, 2025 09:28
@acke acke requested a review from a team as a code owner February 25, 2025 09:28
@acke acke changed the title feat: select treenode on snyk showdocument [WIP] feat: select treenode on snyk showdocument Feb 27, 2025
@acke acke changed the title feat: select treenode on snyk showdocument feat: select treenode on snyk showdocument [IDE-957] Feb 27, 2025
@acke acke force-pushed the feat/IDE-957_code_action_opens_issue_panel branch from 8c50017 to 0829e65 Compare February 27, 2025 13:42
andrewrobinsonhodges-snyk
andrewrobinsonhodges-snyk reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall function/design is good, but you have added a few methods that could do with renaming for clarity, plus a couple of potential bugs with null checks and hard coded parameters.

@andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk mentioned this pull request Feb 27, 2025
Merged
4 tasks
andrewrobinsonhodges-snyk
andrewrobinsonhodges-snyk approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this looks much better. We might want to rename SnykUriDetails or add some explanatory comments later on, as this is pretty specific to this particular URI format at the moment, but it's fine for now.

@acke acke merged commit 3a48531 into main Mar 3, 2025
8 checks passed
@acke acke deleted the feat/IDE-957_code_action_opens_issue_panel branch March 3, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk andrewrobinsonhodges-snyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acke @andrewrobinsonhodges-snyk